On 02/07/14 21:30, Eric Blake wrote:
On 02/07/2014 07:21 AM, Peter Krempa wrote:
According to the documentation describing various tunables for domain timers not all the fields are supported by all the driver types. Express these in the RNG:
- rtc, platform: Only these support the "track" attribute. - tsc: only one to support "frequency" and "mode" attributes - hpet, pit: tickpolicy/catchup attribute/element - kvmclock: no extra attributes are supported --- docs/schemas/domaincommon.rng | 153 +++++++++++++++++++++++++----------------- 1 file changed, 93 insertions(+), 60 deletions(-)
+ <optional> + <element name="catchup"> + <optional> + <attribute name="threshold"> + <ref name="unsignedInt"/> + </attribute> + <attribute name="slew"> + <ref name="unsignedInt"/> + </attribute> + <attribute name="limit"> + <ref name="unsignedInt"/> + </attribute>
Are all three attributes mandatory as a group? Or is each attribute optional in isolation? The C code says the latter, which means this part has to be written:
<element name='catchup'> <optional> <attribute name='threshold'>... </optional> <optional> <attribute name='slew'>...
and so on.
I've fixed this, and
ACK with that fix; it might also be nice to add a testsuite addition that proves we handle 'threshold' without also having to specify 'slew' and 'limit'.
added some tests. The tests also showed that the <catchup> element was being formatted with a spurious space, so I fixed that too in this patch. Pushed now; Thanks. Peter