On 2/21/19 9:50 AM, Peter Krempa wrote:
First 4 patches clean up existing mess.
Note that this series both fixes and then deletes virBufferEscapeN. The split is deliberate, so that if somebody needs virBufferEscapeN in the future they can revert the removal and get a working version.
Peter Krempa (7): util: buffer: Remove misleading AUTOPTR func for 'virBuffer' util: buf: Fix memory leak in virBufferEscapeN tests: buf: Fix debug messages in 'testBufEscapeRegex' util: buf: Remove virBufferEscapeN util: alloc: Introduce 'VIR_AUTOCLEAN' macros for clearing stack'd structs util: buffer: Introduce VIR_AUTOCLEAN function for virBuffer qemu: domain: Use VIR_AUTOCLEAN for virBuffer
Mail delays prevent me from replying directly to the messages that have not hit my inbox yet. I had some minor comments on 5, but trust you can address those. Series: Reviewed-by: Eric Blake <eblake@redhat.com> (And the longer I take to get my incremental backup stuff in, the more I have to rebase it to start using more of these cool macros...) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org