Re: [libvirt] [PATCH 0/3] qmp: query-host-cpu command

On Tue, Jun 21, 2016 at 08:20:40AM +0200, David Hildenbrand wrote: > > Add QMP command to allow management software to query for > > CPU information for the running host. > > > > The data returned by the command is in the form of a dictionary > > of QOM properties. > > > > This series depends on the "Add runnability info to > > query-cpu-definitions" series I sent 2 weeks ago. > > > > Git tree: > > https://github.com/ehabkost/qemu-hacks.git work/query-host-cpu > > > > I like that interface, I'm going to post (maybe today? :) ) a similar interface > that allows to also expand other cpu models, not just the host model. In x86 I want to avoid exposing the details of other CPU models to libvirt because the details depend on machine-type. But if it is useful for you, I believe the same "qom-properties" dict could be returned in query-cpu-definitions. > > Maybe we can then decide which one makes sense for all of us. But in general, > this interface is much better compared to what we had before. Maybe both? I think it's better to have a separate interface for querying "what exactly this host supports" and another one for querying for "what happens if I use -cpu host". In the case of x86, both are equivalent, but we can't guarantee this on all architectures.