I didn't get any feedback on V2, nor any updates if you still reviewing,
but I found myself a few issues.

First in V2 the <source/host> element wasn't optional
(which it should be) and I improved a few error messages,
because sometimes it wasn't clear from where the error
originated.

Best regards,
Rene

Rene Peinthor (3):
  storage: Linstor configuration
  storage: Linstor support
  storage: Add tests for the Linstor storage backend

 docs/schemas/storagepool.rng                  |  27 +
 docs/storage.html.in                          |  39 +
 include/libvirt/libvirt-storage.h             |   1 +
 meson.build                                   |   6 +
 meson_options.txt                             |   1 +
 po/POTFILES.in                                |   1 +
 src/conf/domain_conf.c                        |   1 +
 src/conf/storage_conf.c                       |  13 +-
 src/conf/storage_conf.h                       |   1 +
 src/conf/virstorageobj.c                      |   4 +-
 src/storage/meson.build                       |  25 +
 src/storage/storage_backend.c                 |   6 +
 src/storage/storage_backend_linstor.c         | 783 ++++++++++++++++++
 src/storage/storage_backend_linstor.h         |  24 +
 src/storage/storage_backend_linstor_priv.h    |  53 ++
 src/storage/storage_driver.c                  |   1 +
 src/test/test_driver.c                        |   1 +
 tests/linstorjsondata/broken.json             |   1 +
 tests/linstorjsondata/resource-group.json     |   1 +
 .../linstorjsondata/resource-list-test2.json  | 332 ++++++++
 .../storage-pools-ssdpool.json                |  72 ++
 tests/linstorjsondata/storage-pools.json      | 192 +++++
 tests/linstorjsondata/volume-def-list.json    | 158 ++++
 .../volume-definition-test2.json              |   1 +
 tests/meson.build                             |   6 +
 tests/storagebackendlinstortest.c             | 372 +++++++++
 .../storagepoolcapsschemadata/poolcaps-fs.xml |   7 +
 .../poolcaps-full.xml                         |   7 +
 tests/storagepoolxml2argvtest.c               |   1 +
 tests/storagepoolxml2xmlin/pool-linstor.xml   |   8 +
 tests/storagevolxml2xmlin/vol-linstor.xml     |  10 +
 tools/virsh-pool.c                            |   3 +
 32 files changed, 2156 insertions(+), 2 deletions(-)
 create mode 100644 src/storage/storage_backend_linstor.c
 create mode 100644 src/storage/storage_backend_linstor.h
 create mode 100644 src/storage/storage_backend_linstor_priv.h
 create mode 100644 tests/linstorjsondata/broken.json
 create mode 100644 tests/linstorjsondata/resource-group.json
 create mode 100644 tests/linstorjsondata/resource-list-test2.json
 create mode 100644 tests/linstorjsondata/storage-pools-ssdpool.json
 create mode 100644 tests/linstorjsondata/storage-pools.json
 create mode 100644 tests/linstorjsondata/volume-def-list.json
 create mode 100644 tests/linstorjsondata/volume-definition-test2.json
 create mode 100644 tests/storagebackendlinstortest.c
 create mode 100644 tests/storagepoolxml2xmlin/pool-linstor.xml
 create mode 100644 tests/storagevolxml2xmlin/vol-linstor.xml

--
2.30.0