Re: [libvirt] [PATCH] Support for defining/dumping video device in VirtualBox
On Wed, Aug 19, 2009 at 10:48:45AM +0200, Pritesh Kothari wrote:
On Thursday 13 August 2009 20:50:25 Daniel P. Berrange wrote:
> On Mon, Aug 10, 2009 at 01:55:03PM +0200, Pritesh Kothari wrote:
> > Hi All,
> >
> > I have added support for defining/dumping video device in VirtualBox. The
> > patch for the same is attached here. Also this patch depends on the
> > earlier patch "Support for 3d Acceleration in video tag".
> >
Since the patch "Support for <acceleration> in video tag" has changed,
reposting this patch with necessary changes.
Okay, applied too, I had to change the code to support the fact that
accel is dynamically allocated. I note that there is a lot of VIR_ALLOC
where the return is checked but no error is raised in case of NULL.
I think some cleanup is in order there !
Anyway patch applied and commited,
thanks,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/