Re: [Libvir] [PATCH] Make "make distcheck" work.

Daniel Veillard <veillard(a)redhat.com&gt; wrote: Hi Daniel, Thanks for the thorough review! At first, it does seem like using wildcards is easier than listing the files explicitly, but listing them has advantages: - with wildcards, one can accidentally distribute/install files just because there was a spare .c, .xml, .html file in the wrong directory. With explicit lists, that can't happen. - with the explicit list, you have a record in version control of which files were distributed: less reliance on state of build directory, hence more reproducible. Note that if you forget to add the name of a new file to a list, there is little chance it'll make it past "make distcheck", as long as something depends on the new file. Oh! Thanks. I didn't know that. Will adjust. At the same time, I'll tweak the build rules so that the generated file is read-only. That should serve as a warning to anyone else who is tempted to modify that file directly. New patch coming up...