Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

On Mon, Jan 12, 2009 at 06:29:38PM +0000, Richard W.M. Jones wrote: > On Mon, Dec 15, 2008 at 09:55:19PM +0000, Daniel P. Berrange wrote: > > On Mon, Dec 15, 2008 at 11:05:10AM -0800, john.levon(a)sun.com wrote: > > > ++ > > > ++#if defined(__sun) > > > ++#include <rpc/xdr.h> > > > ++#define u_quad_t uint64_t > > > ++#define quad_t int64_t > > > ++#define xdr_u_quad_t xdr_uint64_t > > > ++#define xdr_quad_t xdr_int64_t > > > ++#define IXDR_GET_LONG IXDR_GET_INT32 > > > > The Linux xdr.h seems to have both sets of definitions in all these > > cases, so I think we can just make rpcgen_fix.pl do this subsitution > > for us. Interestingly, it is already doing s/PUT_LONG/PUT_INT32/ because > > of broken PUT_LONG on Linux. > > FYI PortableXDR's output doesn't need these macros at all. Will still need to the s/quad/int64/ replacement here too