Re: [libvirt] [PATCH 2/5] qemu: domain: Extract parsing and formatting of priv->autoNodeset

On Wed, 2017-07-12 at 15:44 +0200, Peter Krempa wrote:

  static int +qemuDomainObjPrivateXMLParseAutomaticPlacement(virQEMUDriverPtr driver, +                                               qemuDomainObjPrivatePtr priv, +                                               xmlXPathContextPtr ctxt)

I think you should invert the first and last arguments to keep the signature closer to that of the calling function. Reviewed-by: Andrea Bolognani <abologna@redhat.com> --  Andrea Bolognani / Red Hat / Virtualization