Re: [libvirt] [Xen-devel] [PATCH 4/4] xenconfig: fix spice mousemode and copypaste

Fabio Fantoni wrote: > 2015-05-09 0:00 GMT+02:00 Jim Fehlig <jfehlig(a)suse.com > <mailto:jfehlig@suse.com>>: > > From xl.cfg950 man page: > > spiceagent_mouse=BOOLEAN > Whether SPICE agent is used for client mouse mode. The default is > true (1) (turn on) > > spicevdagent=BOOLEAN > Enables spice vdagent. The Spice vdagent is an optional component for > enhancing user experience and performing guest-oriented management > tasks. Its features includes: client mouse mode (no need to grab > mouse by client, no mouse lag), automatic adjustment of screen > resolution, copy and paste (text and image) between client and domU. > It also requires vdagent service installed on domU o.s. to work. > The default is 0. > > spice_clipboard_sharing=BOOLEAN > Enables Spice clipboard sharing (copy/paste). It requires spicevdagent > enabled. The default is false (0). > > So if spiceagent_mouse is enabled (client mouse mode) or > spice_clipboard_sharing is enabled, spicevdagent must be enabled. > Along with this change, s/spicedvagent/spicevdagent, set > spiceagent_mouse correctly, and add a test for these spice > features. > > > Thanks for your work in libvirt about improve/fix support for xen with > spice. > From a fast look to code seems there is spice usbredirection support > missed, a feature that I think very useful: > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=f5414ee57a17500e6... > There are also other spice settings added for xen 4.6 (image > compression and streaming video): > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bd71555985efc423b... > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=296c7f3284efe655d... Right, but those can be added in a follow-up patch. To ease review, I avoided adding support for all features in this patch. > And also another important that you already know and accepted today: > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=161212ef02312c0681d2d... > Latest version have also LIBXL_HAVE_QXL useful for libvirt. Yes. > I think is good add also qxl and usbredir to spice-features test or > create a new one "full features". Agreed. A new test can be added when implementing the addition features in a follow-up. Do you have any interest in working on a libvirt patch for these features?

Regards, Jim