On 30.10.2015 11:46, Martin Kletzander wrote:
On Fri, Oct 30, 2015 at 01:32:34PM +0300, Vasiliy Tolstov wrote:
2015-10-30 13:08 GMT+03:00 Michal Privoznik <mprivozn@redhat.com>:
Yeah, something like that could work. Mind proposing patch?
Maybe... Does it possible to get something like this:
<serial type='unix'> <source mode='bind' path='/tmp/serial.sock'/> <target name='org.qemu....' port='0'/> <alias name='serial2'/> </serial>
i'm not understand does target for serial can have name. qemuFindAgentConfig uses if (STREQ_NULLABLE(channel->target.name, "org.qemu.guest_agent.0")) {
That doesn't make sense to me. virtio channel can have a name, but isa serial cannot, that name wouldn't make sense.
That's the reason why libvirt just doesn't deal with isa-serials as an interface to guest agent. My point is, we need a way in a array of <serials/> to find the correct one that qemu-ga is going to listen to.
Also, how would you identify to which serial port to attach in the guest-agent?
Right now, qemu-ga has -p switch, that allows you to pass the path it should listen to. In this case: qemu-ga -m isa-serial -p /dev/ttyS0 should do. I'm no *BSD-ian, but I bet it can be configured in their startup scripts. So the only question is, how to mark the correct <serial/> in the domain XML. Michal