Re: [libvirt] [PATCH 1/4] snapshot: framework for more efficient relation traversal
On 10/10/2011 08:39 PM, Daniel Veillard wrote:
Okay, agreed then, I was just wondering if more
'canonical' code
and data would lead to simpler code and hence easier to debug in case
of trouble, but we are already in the optimization phase, so fine :-)
>>
>> ACK
>
> I'll wait on your feedback regarding whether I should attempt the
> meta-root concept now, or just push as-is and save a meta-root
> concept for later patches.
Just push now and let see if the meta root patch actually lead to
better code.
I've now pushed 1-4, and am working up a meta-root patch to see if it
looks worthwhile (I'll post it once I get it tested, whether or not I
recommend using or dropping it).
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org