"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
On Tue, Oct 28, 2008 at 12:21:27PM +0100, Jim Meyering wrote:
> From: Jim Meyering <meyering(a)redhat.com>
>
> ---
> qemud/remote_protocol.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/qemud/remote_protocol.c b/qemud/remote_protocol.c
> index 5ef80e5..06b33d8 100644
> --- a/qemud/remote_protocol.c
> +++ b/qemud/remote_protocol.c
> @@ -3,7 +3,6 @@
> * It was generated using rpcgen.
> */
>
> -#include "remote_protocol.h"
> #include <config.h>
> #include "internal.h"
> #include "socketcompat.h"
You're removing it in this patch, but then adding it back in the same
place in a later patch ? Or rather, this is added automatically by
rpcgen when you generate this file...
Nominally, one must not include *anything* before <config.h>,
but since this doesn't cause trouble on systems I tested, I won't
worry about it, for now.
Besides, I shouldn't be modifying manually a generated file.
I'll tweak the build rule to mark the file as read-only,
so that I don't do that again.