Re: [libvirt] [PATCH v2 11/11] virsh: enable domain XML validation by default
On Tue, Jan 13, 2015 at 03:51:47PM +0100, Jiri Denemark wrote:
On Thu, Jan 08, 2015 at 15:48:22 +0000, Daniel Berrange wrote:
> The 'virsh define', 'virsh create' and 'virsh edit'
commands
> get XML validation enabled by default, with a --skip-validate
> option to disable it.
Hmm, I definitely agree with enabling validation for 'virsh edit', which
is something users run interactively. However, enabling it by default
for create and define is something that is likely to cause issues for
scripts that use virsh. I suggest adding --validate option for them so
that it can be enabled by validation should be turned of by default for
them.
Hmm, I guess I see that could be a problem. Even though apps should
always be sending well formed XML, they may have got into the habit
of expecting older libvirt versions to silently ignore elements only
supported by newer libvirt versions. So doing strict validation would
break that.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|