Re: [libvirt PATCH 03/28] util: determine ignoreErrors value when creating rule, not when applying
On 5/2/23 11:15 AM, Michal Prívozník wrote:
On 5/1/23 05:19, Laine Stump wrote:
> + rule->ignoreErrors = ignoreErrors
> + || (group->actionFlags &
VIR_FIREWALL_TRANSACTION_IGNORE_ERRORS);
Nit pick - we usually put logical operands at the end of previous line.
A *very* long time ago (left that company in 1998) I worked with a group
of people who put the operators at the beginning of the line in
multiline expressions. Ever since then everyone I've worked with has
been the opposite, but once or twice a year when I'm "programming while
tired", my brain gets confused about which style was "that was then" and
which style is "this is now".