Re: [libvirt] [PATCH v2] conf: Disallow emulatorpin when numatune's in effect

On Tue, Jan 27, 2015 at 02:25:35PM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1170492 > > In one of our previous commits (dc8b7ce7) we've done a functional > change even though it was intended as pure refactor. The problem is, > that the following XML: > > <vcpu placement='static' current='2'>6</vcpu> > <cputune> > <emulatorpin cpuset='1-3'/> > </cputune> > > gets translated into this one: > > <vcpu placement='auto' current='2'>6</vcpu> > <cputune> > <emulatorpin cpuset='1-3'/> > </cputune> > <numatune> > <memory mode='strict' placement='auto'/> > </numatune> > > We should not change the vcpu placement mode. In the subject you're talking about disallowing <emulatorpin> but here you're talking about not changing vcpu placement, so I'm a little confused about what this patch is actually changing. WRT $SUBJECT though, I don't see why <emulatorpin> should be disallowed when <numatune> is present, as it is valid to pin guest RAM to NUMA nodes and also set emulator pinnning.

Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list