Re: [libvirt] [PATCH 2/9] util: Refactor virResctrlGetInfo in virresctrl
On 2018年07月25日 06:02, John Ferlan wrote:
On 07/18/2018 03:57 AM, bing.niu(a)intel.com wrote:
> From: Bing Niu <bing.niu(a)intel.com>
>
> Separate resctrl common information parts from CAT specific parts,
> so that common information parts can be reused among different
> resource allocation technologies.
>
> Signed-off-by: Bing Niu <bing.niu(a)intel.com>
> ---
> src/util/virresctrl.c | 31 ++++++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 9 deletions(-)
>
I'm assuming you are coordinating with the [RFC PATCHv2 00/10] x86 RDT
Cache Monitoring Technology (CMT) that's on list as well. I don't have
the cycles to do any compare/contrast between the two...
Yup~ Huaqiang in cc list
is working on CMT part. We already sync off
line. Since monitor is more complicated and a brand new implementing to
replace old perf based monitor functions. Huaqiang will absorb Martin's
comment and update his RFC patch. :)
> diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
> index 6d69c8d..98e7296 100644
> --- a/src/util/virresctrl.c
> +++ b/src/util/virresctrl.c
> @@ -318,9 +318,8 @@ virResctrlUnlock(int fd)
>
> /* virResctrlInfo-related definitions */
> static int
> -virResctrlGetInfo(virResctrlInfoPtr resctrl)
> +virResctrlGetCacheInfo(virResctrlInfoPtr resctrl, DIR *dirp)
One argument per line... I can fix before pushing though.
My bad! I should remember
one argument per line for function, instead of
just splitting line only beyond 80 characters. :(
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John