On 07/25/2017 04:25 PM, Michal Privoznik wrote:
<snip/> Moreover, now I can do the following and the code still works:
diff --git i/src/conf/virnetworkobj.c w/src/conf/virnetworkobj.c index ccde72e72..4fe13fc40 100644 --- i/src/conf/virnetworkobj.c +++ w/src/conf/virnetworkobj.c @@ -60 +60 @@ virNetworkObjOnceInit(void) - if (!(virNetworkObjListClass = virClassNew(virClassForObjectLockable(), + if (!(virNetworkObjListClass = virClassNew(virClassForObjectRWLockable(), diff --git i/src/conf/virnetworkobj.h w/src/conf/virnetworkobj.h index 8090c2e24..ee4a939f2 100644 --- i/src/conf/virnetworkobj.h +++ w/src/conf/virnetworkobj.h @@ -30 +30 @@ struct _virNetworkObj { - virObjectLockable parent; + virObjectRWLockable parent;
Hit 'Send' too soon. This should have been: diff --git i/src/conf/virnetworkobj.c w/src/conf/virnetworkobj.c index ccde72e72..82be62832 100644 --- i/src/conf/virnetworkobj.c +++ w/src/conf/virnetworkobj.c @@ -41 +41 @@ struct _virNetworkObjList { - virObjectLockable parent; + virObjectRWLockable parent; @@ -60 +60 @@ virNetworkObjOnceInit(void) - if (!(virNetworkObjListClass = virClassNew(virClassForObjectLockable(), + if (!(virNetworkObjListClass = virClassNew(virClassForObjectRWLockable(), Obviously, rewriting virNetworkObj to use RW locks is gonna require some more work. Michal