Re: Questions regarding potential resize implementation in libvirt

On Thu, 2025-03-20 at 10:28 +0000, Daniel P. Berrangé wrote: > On Thu, Mar 20, 2025 at 11:09:41AM +0100, Maximilian Immanuel > Brandtner wrote: > > On Thu, 2025-03-20 at 09:58 +0000, Daniel P. Berrangé wrote: > > > On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel > > > Brandtner wrote: > > > > I've been working on an RFC patch-set to implement resizing for > > > > consoles in QEMU. Now that the patch-set is in review I've > > > > turned > > > > my > > > > attention to bringing this feature to libvirt. > > > > > > Can you point to the QEMU patchset URL ? > > > > It's not yet on the upstream mailing list as it's still in internal > > review. It should soon be sent to the upstream mailing list. > > Urgh, saying the QEMU patch-set is in review, when you've not even > posted > it yet is more than a little mis-leading :-( From an upstream POV, we > would expect QEMU patches to be published, rather than asking us to > design > an libvirt interface against a private QEMU design we can't even see. Understandable, I just wanted some feedback on how I should implement the feature in libvirt, so that I wouldn't create something that would have to be majorly reworked.