On Tue, Oct 12, 2010 at 09:33:03PM +0200, Matthias Bolte wrote:
2010/10/12 Daniel Veillard <veillard@redhat.com>:
On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote:
From: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
Adding parsing code for memory tunables in the domain xml file
v4: * Add memtune in tests/qemuxml2xmltest.c * Fix: insert memtune element only when any of them is set
v2: + Fix typo min_guarantee
The patch is fine except the usual space and tabs mixups and the fact that a number of drivers still needed to be converted to the change of the definition structure. "grep -- "->memory" src/*/*" isn't that hard and would have shown that even the driver for your own IBM Phyp hardware failed to compile after your patch !!
anyway once cleaned up the patch makes sensei, ACK, but please use "make syntax-check" and do not configure out drivers when you are developping patches,
thanks,
Daniel
This patch should have added documentation about the new XML elements to docs/formatdomain.html.in.
right! virsh man page need to be completed too, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/