Re: [PATCH v3 0/4] Add qemu support setting qos via ovs on ovs interface

On 9/7/21 3:44 PM, Michal Prívozník <mprivozn(a)redhat.com&gt; wrote： On 7/7/21 11:18 AM, zhangjl02 wrote: > --- > > diff to v2: > - Remove passing "actualType" argument, get it inside funtion > - Format code. > > diff to v1: > - Move qemuDomainDefIsOvsport from src/qemu/qemu_domain.c to > src/conf/domain_conf.c > - Call virCommandFree(cmd)free cmd before reusing it. > - Ddd g_autofree to variables. > - Reduce usage of virReportError(), and coupled it with return -1. > - Fix remove port qos error. > - Optimise code structure. > > Thanks to Michal Privoznik for helping reviewing these patches and solving > problems. Really sorry to bring extra work to review them. I will continue > to learn and become familiar with submission process. > > > Now libvirt use tc rules to manage interface's qos. But when an interface > is created by ovs, there is no qos setting result in ovs database. Therefore, > qos of ovs port should be set via ovs management command. > We add a function to tell whether a port definition is an ovs managed virtual > port. Change default qdisc rules, which return 0 directly if the port is ovs > managed(When the ovs port is set noqueue, qos config on this port will not > work). Add ovs management function of setting and cleaning qos. Then check if > the port is an ovs managed port during its life cycle, and call the ovs > management function to set or clean qos settings. > > zhangjl02 (4): > virDomain: interface: add virDomainNetDefIsOvsport > virDomain: interface: add virNetDevOpenvswitchInterfaceSetQos and > virNetDevOpenvswitchInterfaceClearQos > qemu: interface: remove setting noqueue for ovs port > qemu: interface: check and use ovs command to set qos of ovs managed > port > > src/conf/domain_conf.c | 11 ++ > src/conf/domain_conf.h | 2 + > src/libvirt_private.syms | 3 + > src/qemu/qemu_command.c | 10 +- > src/qemu/qemu_domain.c | 3 +- > src/qemu/qemu_driver.c | 23 ++- > src/qemu/qemu_hotplug.c | 35 ++-- > src/qemu/qemu_process.c | 7 +- > src/util/virnetdevopenvswitch.c | 274 ++++++++++++++++++++++++++++++++ > src/util/virnetdevopenvswitch.h | 11 ++ > 10 files changed, 364 insertions(+), 15 deletions(-) > Patches look good. However, you forgot to add Signed-off-by line to each patch (sorry for not realizing earlier). We require it per: https://libvirt.org/hacking.html#developer-certificate-of-origin I can fix that before pushing, just reply to this e-mail with your S-o-b and I will amend that to each commit. Michal