On Wed, Aug 21, 2019 at 12:22:47PM +0200, Ján Tomko wrote:
On Wed, Aug 21, 2019 at 11:01:41AM +0100, Daniel P. Berrangé wrote:
On Thu, Aug 15, 2019 at 02:22:52PM -0700, Sage Imel wrote:
--- src/domain.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
The change looks good, however, we need contributors to assert compliance with the Developer Certificate of Origin:
https://developercertificate.org/
Assuming you're ok with what's described there, you simply need to add 'Signed-off-by: Your Name <your@email>' in the commit message of the change. This can be done with 'git commit -s' (--amend for existing commits)
If you can resend with that done, i'll merge this.
There's a resend of this patch with a sign-off: https://www.redhat.com/archives/libvir-list/2019-August/msg00588.html
however the capitalization does not match the From: field.
Opps, I missed that patch ! Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|