Re: [libvirt] [PATCH 5/7] Implement schedular tunables API using cgroups
On Fri, Jul 17, 2009 at 09:04:27AM -0400, Daniel P. Berrange wrote:
* src/qemu_driver.c: Add driver methods qemuGetSchedulerType,
qemuGetSchedulerParameters, qemuSetSchedulerParameters
[...]
+ for (i = 0; i < nparams; i++) {
+ virSchedParameterPtr param = ¶ms[i];
+
+ if (STREQ(param->field, "cpu_shares")) {
Hum, the type should be checked first as a safety since this comes
directly from the user and those SchedParameter are really error prone.
The name "cpu_shares" need to be documented too.
Once type is checked on input, ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/