Re: [libvirt] [PATCH] docs: comments wiping supported algorithms
On 02/29/2012 04:24 PM, Daniel P. Berrange wrote:
On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote:
> The current scrub version doesn't support pfitzner7, pfitzner33 and schneier
patterns
> on RHEL, we should comment it in virsh man page.
>
> * tools/virsh.pod: update wiping algorithms docs.
>
> Signed-off-by: Alex Jia<ajia(a)redhat.com>
> ---
> tools/virsh.pod | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index c306a38..eba9389 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -2081,6 +2081,8 @@ B<Supported algorithms>
> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33.
> random - 1-pass pattern: random.
>
> +B<Note>: Not all algorithms of wiping are expected to work, it depends on
concrete B<srub> version.
I'd word this slightly differently:
B<note> the availability of algorithms may be limited by the version
of the C<scrub> binary installed on the host.
I'd like this:-)
thanks, I will follow the above modification and
directly push.
Regards,
Daniel