Re: [libvirt PATCH] logging: allow max_len=0 to disable log rollover

On Tue, Oct 13, 2020 at 10:21:58 +0100, Daniel Berrange wrote:

Currently setting max_len=0 causes virtlogd to spin in a busy loop. It is natural to allow this to disable log rollover which can be useful for developers debugging things.

Note disabling rollover exposes the host to denial of service from a malicious guest, so must be used with care.

Closes https://gitlab.com/libvirt/libvirt/-/issues/85 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/logging/virtlogd.conf | 4 ++++ src/util/virrotatingfile.c | 48 +++++++++++++++++++++----------------- 2 files changed, 30 insertions(+), 22 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>