Re: [libvirt] [PATCH 10/10] Move QEMU hotplug helper code out of the QEMU driver

The QEMU driver file is far too large. Move all the hotplug helper code out into a separate file. No functional change. * src/qemu/qemu_hotplug.c, src/qemu/qemu_hotplug.h, src/Makefile.am: Add hotplug helper file * src/qemu/qemu_driver.c: Delete hotplug code --- src/Makefile.am | 1 + src/qemu/qemu_driver.c | 2019 ++++------------------------------------------ src/qemu/qemu_hotplug.c | 1711 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_hotplug.h | 103 +++ 4 files changed, 1991 insertions(+), 1843 deletions(-) create mode 100644 src/qemu/qemu_hotplug.c create mode 100644 src/qemu/qemu_hotplug.h

-static int qemudDomainDetachSCSIDiskDevice(struct qemud_driver *driver, - virDomainObjPtr vm, - virDomainDeviceDefPtr dev, - unsigned long long qemuCmdFlags) +static int qemudDomainAttachDevice(virDomainPtr dom, + const char *xml) { - int i, ret = -1; - virDomainDiskDefPtr detach = NULL; - qemuDomainObjPrivatePtr priv = vm->privateData; + struct qemud_driver *driver = dom->conn->privateData; + virDomainObjPtr vm; + virDomainDeviceDefPtr dev = NULL; + unsigned long long qemuCmdFlags;

+int qemudDomainAttachHostDevice(struct qemud_driver *driver, + virDomainObjPtr vm, + virDomainHostdevDefPtr hostdev, + unsigned long long qemuCmdFlags); +int qemuDomainChangeGraphics(struct qemud_driver *driver, + virDomainObjPtr vm, + virDomainGraphicsDefPtr dev);