Re: [libvirt] [PATCH] qemu: remove capabilities.monitor.sock when done

26 Sep 2014

On Thu, Sep 25, 2014 at 11:12:57AM +0200, Jiri Denemark wrote:
...
On Thu, Sep 25, 2014 at 10:47:55 +0200, Guido Günther wrote:
...
Prompted by
http://bugs.debian.org/761131
---
 src/qemu/qemu_capabilities.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 49f5f75..dca00b2 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3306,6 +3306,7 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps,
     virCommandAbort(cmd);
     virCommandFree(cmd);
     VIR_FREE(monarg);
+    ignore_value(unlink(monpath));
     VIR_FREE(monpath);
     virObjectUnref(vm);
     virObjectUnref(xmlopt);
ACK
Pushed. I've added a check for non-null monpath although glibc seems
to be happy with a NULL argument to unlink I couldn't find this
behaviour specified in POSIX.
Thanks,
 -- Guido

    