Re: [libvirt] [PATCH] virsh: Allow users to reedit rejected XML
On 05/09/2012 09:36 AM, Michal Privoznik wrote:
If users {net-,pool-,}edit but make a mistake in XML all changes
are permanently lost. However, if virsh is running in interactive
mode we can as user if he wants to re-edit the file and correct
the mistakes.
This all reminds me that I so much disliked the idea of creating a .c
file by running sed against virsh.c and then #include'ing that .c file
into virsh.c that I instead made a separate function for
cmdInterfaceEdit rather than adding to it. I had thought that someone
refactored that long ago so that the main bit of code was a helper
function called by all (thus removing the sed trickery), but apparently
we only talked about it. (*adds a line to todo list*)