On Mon, Jan 17, 2022 at 04:19:14PM +0100, Michal Privoznik wrote:
v4 of:
https://listman.redhat.com/archives/libvir-list/2022-January/msg00498.html
diff to v3: - Removed even more code - Switched from virCommandDryRun to a python script, per Andrea's request - Reordered patches so that the mock doesn't need to redirect stat() - Renamed mock - Removed exec() of 'dnsmasq --help'
Michal Prívozník (13): virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty() lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() virdnsmasq: Drop mtime member from struct _dnsmasqCaps virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal() virdnsmasq: Don't run 'dnsmasq --help' virdnsmasq: Lookup DNSMASQ in PATH virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath() networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps networkxml2conftest: Check if capabilities were created successfully virdnsmasq: Drop dnsmasqCapsNewFromBuffer() virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()
Reviewed-by: Andrea Bolognani <abologna@redhat.com> Thanks for bearing with me! -- Andrea Bolognani / Red Hat / Virtualization