On Mon, Feb 19, 2018 at 05:38:35PM +0100, Andrea Bolognani wrote:
When you add a bunch of pcie-root-port controllers to a q35 guest in order to have hotplug capabilities, you also need to make sure you're adding the pcie-root controller at the same time or you will get an error. Document this fact.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- docs/pci-hotplug.html.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/pci-hotplug.html.in b/docs/pci-hotplug.html.in index 6e0648ee2..4ac87d644 100644 --- a/docs/pci-hotplug.html.in +++ b/docs/pci-hotplug.html.in @@ -72,6 +72,7 @@ </p>
<pre> +<controller type='pci' model='pcie-root'/> <controller type='pci' model='pcie-root-port'/> <controller type='pci' model='pcie-root-port'/> <controller type='pci' model='pcie-root-port'/></pre> @@ -80,7 +81,10 @@ if you expect to hotplug up to three PCI Express devices, either emulated or assigned from the host. That's all the information you need to provide: libvirt will fill in the - remaining details automatically. + remaining details automatically. Note that you need to add + the <code>pcie-root</code> controller along with the + <code>pcie-root-port</code> controllers or you will get an + error. </p> <p> Note that if you're adding PCI controllers to a guest and at --
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|