Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

> I am not completely convinced this is what we want. If domain has > exactly one NIC, device-detach semantic is clear. Or if we want to > allow detaching interface by PCI address - MAC shouldn't be > required, because it is redundant. You're missing my point here - virsh is what is broken. It should *not* be trying to guess what the unique attribute the HV driver wants. Each HV may have different decision about this. Applications using the method virDomainDetachDevice, are required to pass the full XML description for the device to be detached as it is currently shown in the guest XML config. virsh really needs to call virDomainDumpXML and then extract the <inteface> element that it wishes to detach, rather than trying to craft some partial XML description on what it thinks the HV might want.