On Thu, Apr 06, 2017 at 10:47:48PM +0200, Wojtek Porczyk wrote:
On Tue, Apr 04, 2017 at 03:31:27PM +0100, Daniel P. Berrange wrote:
> $ python3 ./examples/event-test.py --loop=asyncio --timeout=30 qemu:///session
Thank you for this update. I tested it backported to 3.1.0 with xen:/// using
event-test.py and also with our own code. Looks good to me.
Great, thank you.
I encountered one small problem, which I believe is orthogonal to the
patch series:
On Tue, Apr 04, 2017 at 03:31:32PM +0100, Daniel P. Berrange wrote:
> diff --git a/examples/event-test.py b/examples/event-test.py
> index 751a140..ac9fbe1 100755
> --- a/examples/event-test.py
> +++ b/examples/event-test.py
> + netcallbacks = []
> + netcallbacks.append(vc.networkEventRegisterAny(None,
libvirt.VIR_NETWORK_EVENT_ID_LIFECYCLE, myNetworkEventLifecycleCallback, None))
With vc = libvirt.open('xen:///') and with libvirt{,-python}-3.1.0 this line
causes an
exception:
libvirt.libvirtError: this function is not supported by the
connection driver: virConnectNetworkEventRegisterAny
Commenting it out solves the problem.
Yes, I must say the event test is only validated with the KVM driver, but that said
I thought the Xen driver would get our default nework driver activated automatically,
so I'm surprised you see that.
Regards,
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://entangle-photo.org -o-
http://search.cpan.org/~danberr/ :|