Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs
On Wed, May 13, 2020 at 12:30:48 +0100, Daniel P. Berrangé wrote:
On Wed, May 13, 2020 at 01:19:35PM +0200, Andrea Bolognani wrote:
...
> I completely agree, #nnn is too ambiguous to be useful.
The widespread usage by any other project using GitLab/GitHub proves
otherwise and libvirt isn't special in this regard.
This just means that either everyone uses the reference only as a simple
way of closing the associated issue or they use the web UI to look at
commits.
We're all smart enough to understand this.
It's not really about understanding how to get to the issue. It's about
the effort needed to find the issue. I guess for most commits with the
short reference looking at the original issue would not be worth the
effort of finding it. Which is fine, we can safe time by not looking at
unimportant links.
> We can have a simple prebuild check, similar to the one we
already
> use for DCO checking, which catches uses of
>
> Fixes #nnn
>
> and similar and tells contributors to use a full URL instead.
This is needless extra work for contributors.
I guess I'm a bit strange, but to me pasting a complete link to an issue
is (if I even know such issue exists, of course) less work than
selecting just the number and prefixing it with '#'.
Either way I think fighting about such insignificant point is not the
best use of our time. Let's save it for more important battles we're
going to face, such as the switch to merge requests.
Jirka