Re: [libvirt] [PATCH 00/20] flags cleanup
2011/7/7 Eric Blake <eblake(a)redhat.com>:
On 07/06/2011 05:23 PM, Eric Blake wrote:
> Inspired in part by Laine's recent cleanup of qemuDomainGetXMLDesc,
> in part by my desire to add a new flag to virDomainCoreDump and test
> that older clients reject that flag, and in part by an OCD desire
> for uniformity :), I'm proposing this giant patch series.
And yes, I'm working on a patch 21/20 to cfg.mk to enforce this style in
the future, but ran out of time today.
I'm afraid that you're going to break stuff with this series. For
example the patch for the ESX driver breaks opening a read-only
connection as you made esxOpen reject VIR_CONNECT_RO. Yes, the ESX
driver has no means to support a truly read-only connection as you
always need to provide credentials, so one can consider this a bugfix
or a regression depending on the point-of-view.
--
Matthias Bolte
http://photron.blogspot.com