On 10/25/2010 05:19 AM, Ruben Kerkhof wrote:
On Mon, Oct 25, 2010 at 10:48, Daniel P. Berrange<berrange@redhat.com> wrote:
NACK, this results in 'path' being a zer-length string, so no data is copied in the next virStrcpyStatic line. The original code is correctly creating a socket in the abstract namespace, ie one which does not appear in the filesystem
Daniel
Ah, I didn't knew that, sorry.
Am I right in assuming that an abstract namespace is a linux-only feature? The unix manpage on my Mac doesn't describe it, neither does FreeBSD (http://www.freebsd.org/cgi/man.cgi?query=unix&apropos=0&sektion=0&manpath=FreeBSD+8.1-RELEASE&format=html).
Correct - sun_path starting with a NUL byte is a Linux extension, and not portable to other hosts (except maybe Cygwin). We need to come up with an alternative to the abstract namespace for use on non-Linux hosts. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org