Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh
On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote:
On Thu, 2018-05-03 at 16:46 +0100, Daniel P. Berrangé wrote:
> On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote:
> > The Test-AutoBuild project, that this script is supposed
> > to be used with, hasn't seen any activity in ~7 years;
> > these days, libvirt-sandbox CI builds are happening on the
> > Jenkins-based CentOS CI environment under the libvirt
> > umbrella[1], and in that context the script is not used
> > at all.
> >
> > [1] https://ci.centos.org/view/libvirt/
> >
> > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> > ---
> > autobuild.sh | 71
------------------------------------------------------------
> > 1 file changed, 71 deletions(-)
> > delete mode 100755 autobuild.sh
>
> I used this script when cutting releases. Perhaps it is just something
> to rename to clarify its purpose
I was not aware of that; sorry you had to point that out
several times in response to a bunch of patches.
No worries - notice I didn't object to the python removal, since I'm not
the person doing releases here :-)
Renaming the scripts sounds good to me. Just come up with
a reasonable name and I'll go ahead with another round of
patches.
Perhaps just call it 'make-release.sh' or similar ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|