Re: [libvirt] [PATCH 0/4] Fix a pair of crashes in DNS XML parsing
On Fri, Jul 26, 2013 at 12:28:20PM +0200, Ján Tomko wrote:
*** BLUAAARRRGHB HERE ***
Ján Tomko (4):
Set the number of elements to 0 in virNetwork*Clear
Don't check validity of missing attributes in DNS SRV XML
Remove double space in error messages
Remove redundant free in virNetworkDNSHostDefParseXML
src/conf/network_conf.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
IMHO you should be including one or more test data files to demonstrate
the crash & fix.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|