Re: [libvirt] [PATCH v2 14/21] conf: report an error if nic needs filtering by no driver is present

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote:

If a <interface> includes a filter name but the nwfilter driver is not present we silently do nothing. This is very bad, because an application that thinks it is protected by malicious guest traffic will in fact be vulnerable. Reporting an error gives the administrator the ability to know there is a problem and fix it.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/conf/domain_nwfilter.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: John Ferlan <jferlan@redhat.com> John