Re: [libvirt] [PATCH 14/14] secret: Clean up virSecretObjListExport logic

On Mon, Apr 24, 2017 at 02:00:23PM -0400, John Ferlan wrote:

Shorten the time needed to keep the list lock and alter the cleanup path to be more of an error path.

Utilize the the virObjectListFree function to handle the calls for virObjectUnref on each list element and the VIR_FREE of the list instead of open coding it.

Change the name of the virHashForEach callback to match the name of the Export function with the Callback added onto it.

Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/conf/virsecretobj.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-)

ACK Pavel