Re: [libvirt] [jenkins-ci PATCH 0/6] Update libosinfo (& friends) dependencies

On Wed, 2019-07-31 at 13:56 +0200, Andrea Bolognani wrote: > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote: > > libsoup & mingw-libsoup are new dependencies for both libosinfo & > > osinfo-db-tools since v1.6.0 release > > libcurl & mingw-curl are no longer a dependency for libosinfo since > > v1.5.0 release > > > > Fabiano Fidêncio (6): > > mappings: Add mingw*-libsoup > > mingw*-libosinfo: Add mingw*-libsoup as dependency > > mingw*-osinfo-db-tools: Add mingw*-libsoup as dependency > > osinfo-db-tools: Add libsoup as dependency > > mingw*-libosinfo: Remove mingw*-curl dependency > > ibosinfo: Remove libcurl dependency > > Aside from the typo in 1/6 Dan already pointed out and the question > of the commit message of 2/6 not being AFAICT accurate, one more > meta-comment is that 3-4/6 and 5-6/6 should be squashed together: > I have already done so locally, so as soon as you clear up the > situation for 2/6 I can push the entire series with my > > Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; Oh, forgot to mention: it looks like osinfo-db-tools and libosinfo can no longer be built successfully on Ubuntu 16.04: $ ../autogen.sh --prefix=$VIRT_PREFIX autoreconf: Entering directory `.' autoreconf: running: autopoint --force autopoint: *** The AM_GNU_GETTEXT_VERSION declaration in your configure.ac file requires the infrastructure from gettext-0.19.8 but this version is older. Please upgrade to gettext-0.19.8 or newer. autopoint: *** Stop. autoreconf: autopoint failed with exit status: 1 $ The osinfo-db test suite fails as well. If this was unintentional, then it needs to be addressed; if it was intended, then the data in libvirt-jenkins-ci.git needs to be updated accordingly.