Re: [libvirt] [PATCHv2] maint: Kill usage of atoi()
On 11/15/2013 02:47 AM, Peter Krempa wrote:
On 11/14/13 22:53, Eric Blake wrote:
> On 11/14/2013 02:22 PM, Peter Krempa wrote:
>
>>>> +
>>>> +exclude_file_name_regexp--sc_prohibit_atoi= \
>>>> + ^examples/.*\.[ch]$$
>>>
>>> Drop this hunk. None of our examples/* use atoi to begin with, so
>>> there's no reason to exclude them from the syntax check.
>>>
Well, the file is a bad example by itself. The first issue would be that
it doesn't work. It tries to suspend(pause) a VM using the RO connection.
Hmm. Then let's write that file name exactly (instead of exempting ALL
of examples/*) along with a todo reminder to remove the exemption when
the example is fixed.
That file should be refactored as a whole piece instead of trying to
polish parts that won't even work.
Eww, you're right. All right, I'm okay saving that for another day, so
we don't hold up getting the syntax check in.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)