Re: [libvirt] [PATCH 8/8] Allow balloon driver collection to be adjusted dynamically
On Tue, Jul 02, 2013 at 09:39:26AM -0400, John Ferlan wrote:
Extend the virDomainSetMemeoryFlags() to accept a
'VIR_DOMAIN_MEM_PERIOD'
which will be used to dynamically set the collection period for the balloon
driver via a 'virsh dommemstat <domain> --period <value>' command.
Add
the --current, --live, & --config options to dommemstat.
While what you've done here works from a technical POV, I'm not a
fan of overloading the semantics of the API using a flag. Tuning
memory stat collection period has no semantic overlap with tuning
of memory limits. So I'm inclined to say that we should have a
new dedicated API for tuning the memory stats period.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|