Re: [PATCH v7 0/7] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate
Sure. I'll post NEWS.rst information soon, and really appreciate your help!
Best Regards,
Hao
On 2021/3/18 15:49, Michal Privoznik wrote:
On 3/16/21 1:32 PM, Hao Wang wrote:
> Hao Wang (7):
> migration/dirtyrate: Introduce virDomainStartDirtyRateCalc API
> migration/dirtyrate: Implement qemuDomainStartDirtyRateCalc
> migration/dirtyrate: Introduce domdirtyrate-calc virsh api
> migration/dirtyrate: Introduce virDomainDirtyRateStatus enum
> migration/dirtyrate: Implement qemuMonitorQueryDirtyRate
> migration/dirtyrate: Extend dirtyrate statistics for domGetStats
> migration/dirtyrate: Introduce command 'virsh domstats --dirtyrate'
>
> docs/manpages/virsh.rst | 33 +++++++++-
> include/libvirt/libvirt-domain.h | 23 +++++++
> src/driver-hypervisor.h | 6 ++
> src/libvirt-domain.c | 59 +++++++++++++++++
> src/libvirt_public.syms | 5 ++
> src/qemu/qemu_driver.c | 110 +++++++++++++++++++++++++++++++
> src/qemu/qemu_monitor.c | 24 +++++++
> src/qemu/qemu_monitor.h | 19 +++++
> src/qemu/qemu_monitor_json.c | 101 ++++++++++++++++++++++++++++
> src/qemu/qemu_monitor_json.h | 8 +++
> src/remote/remote_driver.c | 1 +
> src/remote/remote_protocol.x | 14 +++-
> src/remote_protocol-structs | 6 ++
> tools/virsh-domain-monitor.c | 7 ++
> tools/virsh-domain.c | 58 ++++++++++++++++
> 15 files changed, 471 insertions(+), 3 deletions(-)
>
Looks good to me.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Will push shortly. Can you please post a follow up patch that adds NEWS.rst entry? I
think this deserves to be mention in release notes.
Michal
.