Re: [libvirt] PATCH: Support SASL auth for QEMU VNC servers

On Thu, Mar 05, 2009 at 04:37:06PM +0000, Daniel P. Berrange wrote: > This patch adds a config option to /etc/libvirt/qemu.conf to allow the > enablement of SASL authentication of the QEMU VNC servers. The patches > to QEMU are posted upstream, and though their merge is delayed while the > QEMU release is sorted out, I expect them to be merged in a week or so. > I'm posting this patch for review now, though best not to commit it to > CVS until the QEMU stuff is finally merged. [...] > @@ -1295,6 +1315,15 @@ int qemudBuildCommandLine(virConnectPtr > driver->vncTLSx509certdir); > } > } > + > + if (driver->vncSASL) { > + virBufferAddLit(&opt, ",sasl"); > + > + if (driver->vncSASLdir) > + ADD_ENV_PAIR("SASL_CONF_DIR", driver->vncSASLdir); > + > + /* TODO: Support ACLs later */ Just a suggestion: add what dependancy is missing for not adding it immediately so if one hit the comment later it's easier to understand why this is missing and how to fill in. Okay, patch looks fine, but agreed let's wait for the dependancy in QEmu to be commited before pushing this to CVs,