Re: [libvirt] [PATCH v5] Add helper program to create custom leases
On Sat, Apr 26, 2014 at 05:29:16AM +0530, Nehal J Wani wrote:
src/Makefile.am | 22 +++
src/network/bridge_driver.c | 27 ++++
src/network/leaseshelper.c | 360 +++++++++++++++++++++++++++++++++++++++++++
The 'leaseshelper' program also needs to be listed in libvirt.spec.in and
in po/POTFILES.in too.
diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c
new file mode 100644
index 0000000..d580369
--- /dev/null
+++ b/src/network/leaseshelper.c
@@ -0,0 +1,360 @@
+/*
+ * leasehelper.c: Helper program to create custom leases file
typo s/leasehelper/leaseshelper/
+ /* Doesn't hurt to check */
+ if (argc > 1) {
+ if(STREQ(argv[1], "--help"))
Missing space after 'if'
+ usage(EXIT_SUCCESS);
+
+ if (STREQ(argv[1], "--version")) {
+ helperVersion(argv[0]);
+ exit(EXIT_SUCCESS);
+ }
+ }
+ rv = EXIT_SUCCESS;
+
+cleanup:
Missing leading space before 'cleanup'
ACK with the nits fixed.
In the interests of finally getting this merged, I've corrected the
mistakes and pushed the patch. Please remember to use 'make syntax-check'
before sending patches.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|