Re: [libvirt] [PATCH v2 3/3] vbox: Read runtime RDP port and handle autoport

On 10/24/2017 05:09 PM, Dawid Zamirski wrote: > VirutalBox has a IVRDEServerInfo structure available that > gives the effective runtime port that the VM is using when it's > running. This is useful when the "TCP/Ports" VBox property was set > to > port range (e.g. via autoport = "yes" or via VBoxManage) in which > case it would be impossible to get the "active" port otherwise. > --- > src/vbox/vbox_common.c | 3 +- > src/vbox/vbox_tmpl.c | 134 > +++++++++++++++++++++++++++++++----------- > src/vbox/vbox_uniformed_api.h | 2 +- > 3 files changed, 104 insertions(+), 35 deletions(-) > > diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c > index 92ee37164..d542f2b76 100644 > --- a/src/vbox/vbox_common.c > +++ b/src/vbox/vbox_common.c > @@ -3326,7 +3326,8 @@ vboxDumpDisplay(virDomainDefPtr def, > vboxDriverPtr data, IMachine *machine) > if (VIR_ALLOC(graphics) < 0) > goto cleanup; > > - gVBoxAPI.UIVRDEServer.GetPorts(data, VRDEServer, > graphics); > + gVBoxAPI.UIVRDEServer.GetPorts(data, VRDEServer, machine, > graphics); > + gVBoxAPI.UISession.Close(data->vboxSession); But @data is used shortly after this and I don't see in the calling tree a corresponding UISession.Open* of some type or am I missing it in some called function? The rest looks good - just need to know about this. I can remove before pushing or make some other sort of simple adjustment.

John (I'm at KVM Forum in Prague - so normal work schedule is a bit off) > > >