Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

Hmm, thinking aloud here: your patch series has introduced several instances of checking STRPREFIX, then advancing to the end of the prefix. Maybe it's time to introduce a helper macro that does both the check and advances the pointer to the end of the match? Something like: #define STPCMP(ptr, cmp) \ (STRPREFIX (*(ptr), cmp) ? (ptr) += strlen (cmp) : NULL) STPCMP(&tmp, " : "); if (tmp == NULL) error... else use tmp...