Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping
David Stevens/Beaverton/IBM wrote on 03/22/2012 04:22:55 PM:
From: David Stevens/Beaverton/IBM
To: Stefan Berger/Watson/IBM
Cc: "Daniel P. Berrange" <berrange(a)redhat.com>, libvir-list(a)redhat.com
Date: 03/22/2012 04:23 PM
Subject: Re: [libvirt PATCHv6 1/1] add DHCP snooping
Stefan Berger/Watson/IBM wrote on 03/22/2012 12:22:20 PM:
>
> I tried it. It doesn't apply more than one IP address. The code also
> doesn't apply cleanly to the tip.
>
> Stefan
Stefan,
I did a git pull yesterday to which this patch is
applied; here is the last entry before the patch:
commit 25fb4c65a54e3c34c8084b2d49b888d11685a973
Author: Eric Blake <eblake(a)redhat.com>
Date: Tue Mar 20 17:04:38 2012 -0600
build: drop a painfully long gnulib test
Maybe it was my fault while copying and pasting from email app into a VNC
session and tabs got distorted ...
I have some concerns about the cancelation of the thread. It can hold the
snoop lock and get cancelled while holding it. Next time that lock is
grabbed we will get a deadlock...
Stefan
Attachments:
- attachment.html (text/html — 1.8 KB)