On Wed, Jan 03, 2024 at 10:52:11 +0100, Michal Prívozník wrote:
On 1/3/24 10:20, Peter Krempa wrote:
On Fri, Dec 15, 2023 at 13:33:10 +0100, Peter Krempa wrote:
This patch saga aims to improve and simplify testing of qemu XML configs.
Part 1 deals with input test files which are not used in qemuxml2argvtest, introduces a mock network driver and adds a checker that all input files are in fact used.
Peter Krempa (19): qemuxml2argvtest: Reinstate 'console-compat-chardev' and 'pci-serial-dev-chardev' qemuxml2argvtest: Fix and use 'disk-network-ssh-key' case qemuxml2argvtest: Reinstate 'pseries-vio-address-clash' case qemuxml2argvdata: Move 'smbios-multiple-type2' case to genericxml2xmltest qemuxml2argvtest: Remove duplicated invocations of tests qemuxml2argvtest: Check for duplicate invocation of tests qemuxml2argvmock: Mock qemuInterfaceBridgeConnect qemuxml2argvtest: Add test cases covered only by qemuxml2xmltest - part 1 qemuxml2xmltest: Move 'graphics-listen-network2' case go genericxml2xmltest qemuxml2*test: Add specific test case for interface link state qemuxml*test: Improve 'vhost_queues' test case qemuxml2xmltest: Delete 'interface-driver' case qemu: process: Separate setup of network device objects qemuxml2argvmock: Mock virNetDevSetMTU qemuxml2xmltest: Introduce fake network driver qemuxml2argvtest: Enable 'graphics-listen-network' case virnetworkportxml2xmltest: Add simple versions of bridge/network tests qemuxml2argvtest: Add test cases covered only by qemuxml2xmltest - part 2 qemuxml2argvtest: Add checker that all input files are used
Ping? I have part 2 ready already ;) _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org
Looks good. But I'm still getting some unused files:
unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-cdrom-network-nbdkit.xml unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-http-nbdkit.xml unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-source-curl-nbdkit-backing.xml unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-source-curl-nbdkit.xml unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-ssh-key.xml unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-ssh-nbdkit.xml unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-ssh-password.xml
Interesting, all of them pass on my box so we have a environment-dependant test instability here. I'm guessing it's due to the compile time check of nbdkit-backend support. I'll skip the last patch for now and address that one separately.