Re: [libvirt] [PATCH] virnetdevbandwidthtest: Link with libxml2

I've received a notice over IRC that on some systems, the virnetdevbandwidthtest is not linked with libxml: /usr/bin/ld: virnetdevbandwidthtest.o: undefined reference to symbol &#39;xmlStrEqual@(a)LIBXML2_2.4.30&#39; /usr/lib/x86_64-linux-gnu/libxml2.so.2: error adding symbols: DSO missing from command line Trivial way avoiding this is to add LIBXML_LIBS to virnetdevbandwidthtest_LDADD. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am index cfc0905..91c385e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -658,7 +658,7 @@ commandhelper_LDFLAGS = -static virnetdevbandwidthtest_SOURCES = \ virnetdevbandwidthtest.c testutils.h testutils.c -virnetdevbandwidthtest_LDADD = $(LDADDS) +virnetdevbandwidthtest_LDADD = $(LDADDS) $(LIBXML_LIBS) if WITH_LIBVIRTD libvirtdconftest_SOURCES = \