Re: [libvirt] [PATCH 3/5] phyp: Don't try to use a string from a failed virAsprintf

11 Apr 2011

On Sat, Apr 09, 2011 at 11:59:09AM +0200, Matthias Bolte wrote:
...
---
 src/phyp/phyp_driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index f441261..24165fb 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -210,7 +210,7 @@ phypGetSystemType(virConnectPtr conn)
if (virAsprintf(&cmd, "lshmc -V") < 0) {
         virReportOOMError();
-        exit_status = -1;
+        return -1;
     }
     ret = phypExec(session, cmd, &exit_status, conn);
ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

    